Update gitbase dependencies and turnoff proto logs. #422
Conversation
|
@kuba-- please, rebase with master, you have a commit from @erizocosmico |
Signed-off-by: kuba-- <[email protected]>
|
@ajnavarro - rebased. |
|
After merge into the master it closes: #413 |
cmd/gitbase/command/server.go
Outdated
| @@ -193,6 +194,7 @@ func (c *Server) registerDrivers() error { | |||
| logrus.Debug("established connection with pilosa") | |||
|
|
|||
| c.engine.Catalog.RegisterIndexDriver(pilosa.NewDriver(c.IndexDir, client)) | |||
| c.engine.Catalog.RegisterIndexDriver(pilosalib.NewDriver(c.IndexDir)) | |||
There was a problem hiding this comment.
should we use another folder for that driver? maybe we can create a mess if we name two indexes in the same way from different drivers.
There was a problem hiding this comment.
We can do that, but in theory it should work, because it's a root folder where mapping and config file goes. Mapping and Config are the same. The only concern I have if someone wants to create a 2 indexes for the same expression (but I think it's not possible).
So for old pilosa mapping and config goes to root/db/table/id with names config.yml, mapping.db. Config contains information about what driver was used to create an index.
An extra metadata for pilosalib goes under to .pilosalib folder under id folder.
So it's up to us. if we want to have 2 different roots per driver.
There was a problem hiding this comment.
I would prefer two folders to avoid unexpected problems.
There was a problem hiding this comment.
ok, fair enough - I've sent an update
Signed-off-by: kuba-- <[email protected]>
Signed-off-by: kuba-- <[email protected]>
Signed-off-by: kuba-- <[email protected]>
|
FYI: I modified |
Signed-off-by: kuba-- [email protected]
This commit updates dependencies and registers a new index driver (
pilosalib).Because packages
go-pilosaandpilosashare and register the same types in protobufs we have to double check if type was already registered. This is temporary fix to avoid logging duplicate proto type registered when gitbase starts.